Bug 228280 - Fix undefined behavior when querying linux memory size
Summary: Fix undefined behavior when querying linux memory size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail R. Gadelha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-26 08:07 PDT by Mikhail R. Gadelha
Modified: 2022-02-03 09:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.06 KB, patch)
2021-07-26 08:20 PDT, Mikhail R. Gadelha
no flags Details | Formatted Diff | Diff
Patch (4.20 KB, patch)
2021-09-21 05:41 PDT, Mikhail R. Gadelha
no flags Details | Formatted Diff | Diff
Patch (4.18 KB, patch)
2022-02-01 11:14 PST, Mikhail R. Gadelha
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail R. Gadelha 2021-07-26 08:07:06 PDT
Fix undefined behavior when querying linux memory size
Comment 1 Mikhail R. Gadelha 2021-07-26 08:20:01 PDT
Created attachment 434207 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-08-02 08:08:18 PDT
<rdar://problem/81411993>
Comment 3 Mikhail R. Gadelha 2021-09-21 05:41:49 PDT
Created attachment 438810 [details]
Patch
Comment 4 Mikhail R. Gadelha 2022-02-01 11:14:49 PST
Created attachment 450551 [details]
Patch
Comment 5 Mark Lam 2022-02-02 10:22:39 PST
Comment on attachment 450551 [details]
Patch

LGTM
Comment 6 EWS 2022-02-03 07:30:28 PST
Committed r289056 (246763@main): <https://commits.webkit.org/246763@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450551 [details].
Comment 7 ujwal koneru 2022-02-03 09:12:41 PST
Is the removal of header file for freebsd(sysinfo.h) intended? This fails playstation builds.
Comment 8 Mikhail R. Gadelha 2022-02-03 09:21:01 PST
Unintended change, I'll fix that rn.