Bug 22827 - RenderThemeWin buttons have weird heavy text
Summary: RenderThemeWin buttons have weird heavy text
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2008-12-12 13:56 PST by Adele Peterson
Modified: 2008-12-16 17:55 PST (History)
2 users (show)

See Also:

patch (3.13 KB, patch)
2008-12-12 13:59 PST, Adele Peterson
no flags Details | Formatted Diff | Diff
now with changelog (3.86 KB, patch)
2008-12-16 17:05 PST, Adele Peterson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2008-12-12 13:56:30 PST
RenderThemeWin buttons have weird heavy text
Comment 1 Adele Peterson 2008-12-12 13:59:29 PST
Created attachment 25986 [details]

Potential fix.  Not sure if the default GUI font is right here.  But it matches Firefox.
Comment 2 Dave Hyatt 2008-12-12 14:15:02 PST
This is wrong IMO.

-    fontDescription.setSpecifiedSize(abs(logFont.lfHeight));
+    fontDescription.setSpecifiedSize(fontSize);

Just pass in the size you want instead.  It's an argument to fillFontDescription, so i don't see why you'd ignore the argument.

The rest of it looks good.  Eyeballing Mozilla's code they do indeed use the stock DEFAULT_GUI_FONT for buttons.

Comment 3 Adele Peterson 2008-12-16 17:05:20 PST
Created attachment 26079 [details]
now with changelog

The patch does explicitly set the font size for the controls, and after Hyatt and I talked more about the patch, I think this is right.

Chromium has a slightly different strategy that we may want to merge with in the future.  But for now, this will get us closer to a reasonable control look w/ RenderThemeWin.
Comment 4 Darin Adler 2008-12-16 17:41:14 PST
Comment on attachment 26079 [details]
now with changelog

Comment 5 Adele Peterson 2008-12-16 17:55:43 PST
Committed r39349