Bug 228266 - [GTK] USE_OPENGL_OR_ES should not be an automagic feature
Summary: [GTK] USE_OPENGL_OR_ES should not be an automagic feature
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Reported: 2021-07-24 08:24 PDT by Michael Catanzaro
Modified: 2021-07-25 11:29 PDT (History)
8 users (show)

See Also:

Patch (2.69 KB, patch)
2021-07-24 08:37 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2021-07-24 08:24:25 PDT
The USE_OPENGL_OR_ES feature flag added in r271220 is currently automagic: that is, if neither OpenGL nor OpenGL ES is available at build time, it gets silently disabled. This is not OK because it makes it easy for distributors to accidentally fail to enable OpenGL support. We should require manually disabling the feature with -DUSE_OPENGL_OR_ES=OFF in order to build with OpenGL disabled.
Comment 1 Michael Catanzaro 2021-07-24 08:27:03 PDT
Note that automagic detection of OpenGL ES is OK because that is not a "feature." It doesn't matter to the user whether OpenGL or OpenGL ES gets used under the hood. But it matters very much if neither is used at all.
Comment 2 Michael Catanzaro 2021-07-24 08:37:04 PDT
Created attachment 434169 [details]
Comment 3 Fujii Hironori 2021-07-24 15:06:34 PDT
Comment on attachment 434169 [details]

It's my mistake. Thank you.
Comment 4 Michael Catanzaro 2021-07-25 10:59:55 PDT
Comment on attachment 434169 [details]

No problem. Build options are hard....
Comment 5 EWS 2021-07-25 11:29:34 PDT
Committed r280287 (239945@main): <https://commits.webkit.org/239945@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434169 [details].