Bug 228257 – [JSC] Add Speedometer2 jQuery-TodoMVC RegExp microbenchmark

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Add Speedometer2 jQuery-TodoMVC RegExp microbenchmark

[Yusuke Suzuki]

Created attachment 434152 [details]
Patch

[Yusuke Suzuki]

Created attachment 434153 [details]
Patch

[Yusuke Suzuki]

It is successfully capturing Speedometer2/jQuery-TodoMVC's regexps.


Sampling rate: 1000.000000 microseconds. Total samples: 620
Top functions as <numSamples  'functionName#hash:sourceID'>
   287    '/<(?!area|br|col|embed|hr|img|input|link|meta|param)(([a-z][^\/\0>\x20\t\r\n\f]*)[^>]*)\/>/gi#<nil>:-1'
   173    '/<script|<style|<link/i#<nil>:-1'
    48    '/[&<>"'`=]/#<nil>:-1'
    20    'test#<nil>:1'
    15    'JSC::RegExpObject::execInline(JSC::JSGlobalObject*, JSC::JSString*)#<nil>:-1'
     7    'JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<char16_t> >::parseAssignmentExpression<JSC::ASTBuilder>(JSC::ASTBuilder&, JSC::Parser<JSC::Lexer<char16_t> >::ExpressionErrorClassifier&)#<nil>:-1'
     5    'JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<char16_t> >::parseMemberExpression<JSC::ASTBuilder>(JSC::ASTBuilder&)#<nil>:-1'
     5    'JSC::Lexer<char16_t>::lexWithoutClearingLineTerminator(JSC::JSToken*, WTF::OptionSet<JSC::LexerFlags>, bool)#<nil>:-1'
     3    'JSC::BytecodeGenerator::needsTDZCheck(JSC::Variable const&)#<nil>:-1'
     3    'JSC::BytecodeGenerator::variable(JSC::Identifier const&, JSC::ThisResolutionType)#<nil>:-1'
     2    '/^[\x20\t\r\n\f]+|((?:^|[^\\])(?:\\.)*)[\x20\t\r\n\f]+$/g#<nil>:-1'
     2    'WTF::SmallSet<WTF::UniquedStringImpl*, WTF::PtrHashBase<WTF::UniquedStringImpl*, false>, 8u>::add(WTF::UniquedStringImpl*)#<nil>:-1'

[Mark Lam]

Comment on attachment 434153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434153&action=review

r=me

> JSTests/microbenchmarks/jquery-todomvc-regexp.js:3


You can just say `//@ runDefault`.  Don't need the parens if you're not specifying any additional options.

[Yusuke Suzuki]

(In reply to Mark Lam from comment #4)
> Comment on attachment 434153 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434153&action=review
> 
> r=me
> 
> > JSTests/microbenchmarks/jquery-todomvc-regexp.js:3
> 
> 
> You can just say `//@ runDefault`.  Don't need the parens if you're not
> specifying any additional options.

Oops, fixed.

[Yusuke Suzuki]

Committed r280281 (239939@main): <https://commits.webkit.org/239939@main>

[Radar WebKit Bug Importer]

<rdar://problem/81047088>