Bug 228257 - [JSC] Add Speedometer2 jQuery-TodoMVC RegExp microbenchmark
Summary: [JSC] Add Speedometer2 jQuery-TodoMVC RegExp microbenchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-23 17:18 PDT by Yusuke Suzuki
Modified: 2021-07-23 20:41 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.31 MB, patch)
2021-07-23 18:04 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (11.28 MB, patch)
2021-07-23 18:10 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-07-23 17:18:53 PDT 
[JSC] Add Speedometer2 jQuery-TodoMVC RegExp microbenchmark
Comment 1 Yusuke Suzuki 2021-07-23 18:04:50 PDT 
Created attachment 434152 [details]
Patch
Comment 2 Yusuke Suzuki 2021-07-23 18:10:31 PDT 
Created attachment 434153 [details]
Patch
Comment 3 Yusuke Suzuki 2021-07-23 19:17:18 PDT 
It is successfully capturing Speedometer2/jQuery-TodoMVC's regexps.


Sampling rate: 1000.000000 microseconds. Total samples: 620
Top functions as <numSamples  'functionName#hash:sourceID'>
   287    '/<(?!area|br|col|embed|hr|img|input|link|meta|param)(([a-z][^\/\0>\x20\t\r\n\f]*)[^>]*)\/>/gi#<nil>:-1'
   173    '/<script|<style|<link/i#<nil>:-1'
    48    '/[&<>"'`=]/#<nil>:-1'
    20    'test#<nil>:1'
    15    'JSC::RegExpObject::execInline(JSC::JSGlobalObject*, JSC::JSString*)#<nil>:-1'
     7    'JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<char16_t> >::parseAssignmentExpression<JSC::ASTBuilder>(JSC::ASTBuilder&, JSC::Parser<JSC::Lexer<char16_t> >::ExpressionErrorClassifier&)#<nil>:-1'
     5    'JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<char16_t> >::parseMemberExpression<JSC::ASTBuilder>(JSC::ASTBuilder&)#<nil>:-1'
     5    'JSC::Lexer<char16_t>::lexWithoutClearingLineTerminator(JSC::JSToken*, WTF::OptionSet<JSC::LexerFlags>, bool)#<nil>:-1'
     3    'JSC::BytecodeGenerator::needsTDZCheck(JSC::Variable const&)#<nil>:-1'
     3    'JSC::BytecodeGenerator::variable(JSC::Identifier const&, JSC::ThisResolutionType)#<nil>:-1'
     2    '/^[\x20\t\r\n\f]+|((?:^|[^\\])(?:\\.)*)[\x20\t\r\n\f]+$/g#<nil>:-1'
     2    'WTF::SmallSet<WTF::UniquedStringImpl*, WTF::PtrHashBase<WTF::UniquedStringImpl*, false>, 8u>::add(WTF::UniquedStringImpl*)#<nil>:-1'
Comment 4 Mark Lam 2021-07-23 20:00:19 PDT 
Comment on attachment 434153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434153&action=review

r=me

> JSTests/microbenchmarks/jquery-todomvc-regexp.js:3


You can just say `//@ runDefault`.  Don't need the parens if you're not specifying any additional options.
Comment 5 Yusuke Suzuki 2021-07-23 20:33:25 PDT 
(In reply to Mark Lam from comment #4)
> Comment on attachment 434153 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434153&action=review
> 
> r=me
> 
> > JSTests/microbenchmarks/jquery-todomvc-regexp.js:3
> 
> 
> You can just say `//@ runDefault`.  Don't need the parens if you're not
> specifying any additional options.

Oops, fixed.
Comment 6 Yusuke Suzuki 2021-07-23 20:40:55 PDT 
Committed r280281 (239939@main): <https://commits.webkit.org/239939@main>
Comment 7 Radar WebKit Bug Importer 2021-07-23 20:41:22 PDT 
<rdar://problem/81047088>