Bug 228227 – [GTK][WPE] Add API to pass WebKitMemoryPressureHandler parameters to the network processes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

Now that WebKitMemoryPressureSettings have been added to WebKitGTK and WPE in bug 222738, we need a way to pass these settings to the network processes as well.

[Miguel Gomez]

Created attachment 434081 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 434081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434081&action=review

> Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp:42
> +    static const char* disableMemoryPressureMonitor = getenv("WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR");

Since this is static, you should check if we already have a value before getting it again.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:823
> +        WebKitMemoryPressureSettings* settings = webkit_memory_pressure_settings_new();
> +        webkit_website_data_manager_set_memory_pressure_settings(settings);
> +        webkit_memory_pressure_settings_free(settings);

Since the config is std::optional, I think we can allow to pass NULL and pass std::optional to the process pool

[Miguel Gomez]

Created attachment 435483 [details]
Patch

[EWS]

Committed r281070 (240531@main): <https://commits.webkit.org/240531@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435483 [details].