RESOLVED INVALID Bug 22821
Combine op_bitand and op_jfalse instructions 
https://bugs.webkit.org/show_bug.cgi?id=22821
Summary Combine op_bitand and op_jfalse instructions
Gabor Loki
Reported 2008-12-12 02:25:45 PST
I have found about 1% progression if we combine op_bitand and op_jfalse instructions. I am going to attach the patch and the results.
Attachments
Add op_jnbitand instruction (11.23 KB, patch)
2008-12-12 02:27 PST, Gabor Loki 		no flags
DetailsFormatted DiffDiff
SunSpider, V8, WindScorpion results (non-jit) (4.56 KB, text/plain)
2008-12-12 02:28 PST, Gabor Loki 		no flags
Details
SunSpider, V8, WindScorpion results (JIT) (4.16 KB, text/plain)
2008-12-12 02:28 PST, Gabor Loki 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2008-12-12 02:27:49 PST
Created attachment 25976 [details] Add op_jnbitand instruction
Gabor Loki
Comment 2 2008-12-12 02:28:36 PST
Created attachment 25977 [details] SunSpider, V8, WindScorpion results (non-jit)
Gabor Loki
Comment 3 2008-12-12 02:28:57 PST
Created attachment 25978 [details] SunSpider, V8, WindScorpion results (JIT)
Oliver Hunt
Comment 4 2009-01-22 18:36:38 PST
Comment on attachment 25976 [details] Add op_jnbitand instruction Alas, i think the jit code for this is too out of date to be useful anymore, the code itself looks fine, so rather than r- i'll just clear the review flag. sorry for the huge delay in review time.
Gabor Loki
Comment 5 2009-05-13 05:02:37 PDT
I did the performance test again on x86 without JIT, and there was no more progression.
Gavin Barraclough
Comment 6 2012-09-06 17:52:12 PDT
This patch won't still apply; this kind of optimization is now more appropriate in the DFG JIT.
Note You need to log in before you can comment on or make changes to this bug.