Bug 228201 - [macOS] Correct two sandbox typos
Summary: [macOS] Correct two sandbox typos
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 226066 228112
Blocks:
  Show dependency tree / graph
 
Reported: 2021-07-22 14:58 PDT by Brent Fulgham
Modified: 2021-07-22 15:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2021-07-22 15:07 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-07-22 14:58:11 PDT 
While investigating a bug I noticed two typos in the sandbox file:

(1) A regex is defined improperly:

    (home-regex "/Library/Preferences/ByHost/\.GlobalPreferences\..*\.plist$")

... should be:

    (home-regex #"/Library/Preferences/ByHost/\.GlobalPreferences\..*\.plist$")

(2) I broke an "(if " form by adding a second rule, which made the original rule become the "else" part of the logic.
Comment 1 Radar WebKit Bug Importer 2021-07-22 14:58:27 PDT 
<rdar://problem/80983916>
Comment 2 Brent Fulgham 2021-07-22 15:07:40 PDT 
Created attachment 434038 [details]
Patch
Comment 3 Per Arne Vollan 2021-07-22 15:10:12 PDT 
Comment on attachment 434038 [details]
Patch

R=me.
Comment 4 EWS 2021-07-22 15:49:00 PDT 
Committed r280203 (239891@main): <https://commits.webkit.org/239891@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434038 [details].