Bug 228193 - AirStackSlot's uint16_t byte size is too small
Summary: AirStackSlot's uint16_t byte size is too small
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-22 13:20 PDT by Saam Barati
Modified: 2021-07-22 14:37 PDT (History)
6 users (show)

See Also:

Attachments
patch (8.54 KB, patch)
2021-07-22 13:25 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-07-22 13:20:25 PDT 
...
Comment 1 Saam Barati 2021-07-22 13:21:07 PDT 
<rdar://80888059>
Comment 2 Saam Barati 2021-07-22 13:25:23 PDT 
Created attachment 434030 [details]
patch
Comment 3 Mark Lam 2021-07-22 13:30:55 PDT 
Comment on attachment 434030 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434030&action=review

r=me

> Source/JavaScriptCore/b3/B3Procedure.cpp:76
> +Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize)

Let's use size_t instead of uint64_t in all these size values.
Comment 4 Saam Barati 2021-07-22 14:31:57 PDT 
Comment on attachment 434030 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434030&action=review

>> Source/JavaScriptCore/b3/B3Procedure.cpp:76
>> +Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize)
> 
> Let's use size_t instead of uint64_t in all these size values.

I picked uint64_t explicitly just so this code would work if we ever ported to 32-bit.
Comment 5 EWS 2021-07-22 14:37:08 PDT 
Committed r280198 (239886@main): <https://commits.webkit.org/239886@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434030 [details].