Bug 228184 – Compilation error with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Víctor M. Jáquez L.]

While cross compiling with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90) 

I hit with this compilation error:

WebCore/DerivedSources/JSRTCRtpSender.cpp: In function ‘JSC::JSValue WebCore::toJSNewlyCreated(JSC::JSGlobalObject*, WebCore::JSDOMGlobalObject*, WTF::Ref<WebCore::RTCRtpSender>&&)’:
WebCore/DerivedSources/JSRTCRtpSender.cpp:500:54: error: static assertion failed: RTCRtpSender is not polymorphic
  500 |     static_assert(std::is_polymorphic<RTCRtpSender>::value, "RTCRtpSender is not polymorphic");
      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~

[Víctor M. Jáquez L.]

Created attachment 434014 [details]
Patch

[Chris Dumez]

Comment on attachment 434014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434014&action=review

> Source/WebCore/Modules/mediastream/RTCRtpReceiver.h:59
> +    virtual ~RTCRtpReceiver();

Oh, that's because your port doesn't subclass LoggerHelper.

[Víctor M. Jáquez L.]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 434014 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434014&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCRtpReceiver.h:59
> > +    virtual ~RTCRtpReceiver();
> 
> Oh, that's because your port doesn't subclass LoggerHelper.

Thanks! Let me look at it :)

[Víctor M. Jáquez L.]

But still, LoggerHelper inheritance is conditional...

[EWS]

Committed r280179 (239873@main): <https://commits.webkit.org/239873@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434014 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80968862>