Bug 228181 - REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst
Summary: REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-22 02:57 PDT by Tim Horton
Modified: 2021-07-22 11:04 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2021-07-22 02:58 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2021-07-22 10:34 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-07-22 02:57:34 PDT 
REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst
Comment 1 Tim Horton 2021-07-22 02:58:11 PDT 
Created attachment 434002 [details]
Patch
Comment 2 Tim Horton 2021-07-22 02:58:15 PDT 
<rdar://problem/80923581>
Comment 3 Daniel Bates 2021-07-22 10:09:49 PDT 
Comment on attachment 434002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434002&action=review

Patch looks good.

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:429
> +    RetainPtr<id> contents = nil;

OK as-is. No change needed. Thoughts about removing the = nil and letting the default constructor initialize this?
Comment 4 Tim Horton 2021-07-22 10:24:28 PDT 
(In reply to Daniel Bates from comment #3)
> Comment on attachment 434002 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434002&action=review
> 
> Patch looks good.
> 
> > Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:429
> > +    RetainPtr<id> contents = nil;
> 
> OK as-is. No change needed. Thoughts about removing the = nil and letting
> the default constructor initialize this?

Heh, sure, certainly.
Comment 5 Tim Horton 2021-07-22 10:34:42 PDT 
Created attachment 434018 [details]
Patch
Comment 6 EWS 2021-07-22 11:04:10 PDT 
Committed r280183 (239876@main): <https://commits.webkit.org/239876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434018 [details].