Bug 228177 - [Cocoa] Stop honoring any dot-prefixed font names
Summary: [Cocoa] Stop honoring any dot-prefixed font names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-22 01:34 PDT by Myles C. Maxfield
Modified: 2021-09-03 15:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.76 KB, patch)
2021-07-22 01:34 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (21.09 KB, patch)
2021-07-23 23:22 PDT, Myles C. Maxfield
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-07-22 01:34:10 PDT
[Cocoa] Stop honoring any dot-prefixed font names
Comment 1 Myles C. Maxfield 2021-07-22 01:34:29 PDT
Created attachment 433997 [details]
Patch
Comment 2 Myles C. Maxfield 2021-07-22 01:35:19 PDT
This might have to be a linked-on-or-after check, or new SPI.
Comment 3 Myles C. Maxfield 2021-07-22 02:20:42 PDT
Tests that failed on Monterey:

fast/text/font-lookup-dot-prefix-case-sensitive.html
  => This test should be deleted
fast/text/trak-optimizeLegibility.html
  => This test should be investigated
svg/dom/altGlyph-dom.xhtml
  => This is probably a rebaseline.
Comment 4 Myles C. Maxfield 2021-07-22 02:21:54 PDT
(In reply to Myles C. Maxfield from comment #3)
> Tests that failed on Monterey:
> 
> fast/text/font-lookup-dot-prefix-case-sensitive.html
>   => This test should be deleted
Actually, not deleted, but the -expected-mismatch should turn into an -expected.
Comment 5 Myles C. Maxfield 2021-07-22 15:38:37 PDT
These same tests are the tests that fail on Big Sur.
Comment 6 Myles C. Maxfield 2021-07-23 23:22:47 PDT
Created attachment 434158 [details]
Patch
Comment 7 Myles C. Maxfield 2021-07-24 14:07:07 PDT
Thanks for the review! I can't land this just yet at this point in the release cycle.
Comment 8 Radar WebKit Bug Importer 2021-07-29 01:35:47 PDT
<rdar://problem/81259420>
Comment 9 Myles C. Maxfield 2021-08-19 21:07:20 PDT
Committed r281293 (240717@main): <https://commits.webkit.org/240717@main>
Comment 10 Myles C. Maxfield 2021-09-03 15:02:19 PDT
Committed r282027 (241331@main): <https://commits.webkit.org/241331@main>