Bug 228176 - [Cocoa] Stop treating the system font as a non-variable font
Summary: [Cocoa] Stop treating the system font as a non-variable font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 221223 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-07-22 01:18 PDT by Myles C. Maxfield
Modified: 2021-09-03 21:34 PDT (History)
6 users (show)

See Also:

Attachments
WIP (2.48 KB, patch)
2021-07-22 01:20 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (18.69 KB, patch)
2021-07-23 14:12 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (21.55 KB, patch)
2021-07-23 18:13 PDT, Myles C. Maxfield 		sam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-07-22 01:18:34 PDT 
[Cocoa] Stop treating the system font as a non-variable font
Comment 1 Myles C. Maxfield 2021-07-22 01:20:21 PDT 
Created attachment 433996 [details]
WIP
Comment 2 Myles C. Maxfield 2021-07-22 01:25:15 PDT 
There are lots of failures on Catalina.
Comment 3 Myles C. Maxfield 2021-07-22 13:39:07 PDT 
On Big Sur, the failures are:

fast/text/trak-optimizeLegibility.html
fast/text/design-system-ui-7.html
Comment 4 Myles C. Maxfield 2021-07-22 13:41:04 PDT 
So I think this has to be Monterey and later because fast/text/design-system-ui-7.html probably won't be able to be fixed on Big Sur.
Comment 5 Myles C. Maxfield 2021-07-23 14:12:50 PDT 
Created attachment 434118 [details]
Patch
Comment 6 Myles C. Maxfield 2021-07-23 15:47:06 PDT 
Comment on attachment 434118 [details]
Patch

Oh, I need to make the test only valid on certain OSes.
Comment 7 Myles C. Maxfield 2021-07-23 18:13:34 PDT 
Created attachment 434154 [details]
Patch
Comment 8 Sam Weinig 2021-07-24 11:06:12 PDT 
Comment on attachment 434154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434154&action=review

> Source/WTF/ChangeLog:8
> +        * wtf/PlatformUse.h:

This kinda feels like it should be a HAVE_ since it is about whether a specific system feature is available and not a policy about using an optional library or service.
Comment 9 Myles C. Maxfield 2021-07-24 14:07:16 PDT 
Thanks for the review! I can't land this just yet at this point in the release cycle.
Comment 10 Radar WebKit Bug Importer 2021-07-29 01:19:15 PDT 
<rdar://problem/81258915>
Comment 11 Myles C. Maxfield 2021-08-08 14:13:07 PDT 
*** Bug 221223 has been marked as a duplicate of this bug. ***
Comment 12 EWS 2021-08-19 18:30:03 PDT 
Tools/Scripts/svn-apply failed to apply attachment 434154 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 13 Myles C. Maxfield 2021-08-19 20:21:17 PDT 
Committed r281291 (240715@main): <https://commits.webkit.org/240715@main>
Comment 14 Myles C. Maxfield 2021-09-03 21:34:57 PDT 
Committed r282044 (241344@main): <https://commits.webkit.org/241344@main>