Bug 228175 - Expose document ordering in WebKit internals object
Summary: Expose document ordering in WebKit internals object
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-21 23:27 PDT by Frédéric Wang (:fredw)
Modified: 2021-07-28 23:28 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2021-07-21 23:27:35 PDT 
Currently tree ordering is tested by Tools/TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp
For this purpose, documentOrder() is WEBKIT_EXPORTed.

Instead, we should expose these in WebKit internals object, then replace DocumentOrder.cpp with tests written in JavaScript.
Comment 1 Darin Adler 2021-07-23 12:30:28 PDT 
Alternatively, we may be able to export template implementations by using WEBCORE_EXPORT on the explicit template instantiations as we do in JSDOMConvertNumbers.h.
Comment 2 Frédéric Wang (:fredw) 2021-07-23 12:44:22 PDT 
(In reply to Darin Adler from comment #1)
> Alternatively, we may be able to export template implementations by using
> WEBCORE_EXPORT on the explicit template instantiations as we do in
> JSDOMConvertNumbers.h.

mmh, I had tried something like that but obtained build failures. It's worth trying again though.
Comment 3 Radar WebKit Bug Importer 2021-07-28 23:28:16 PDT 
<rdar://problem/81255637>