pageUp/fn+up-arrow and pageDown/fn+down-arrow are not smooth.
<rdar://problem/80911788>
Created attachment 434784 [details] Patch
Created attachment 434785 [details] Patch
Comment on attachment 434785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434785&action=review > Source/WebCore/ChangeLog:10 > + No tests yet. Maybe this is a good opportunity to start porting the iOS keyboard scrolling tests? I think there is one specifically about pageUp/Down > Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:269 > + [self.nextResponder tryToPerform:_cmd with:sender]; I think you need to return here, not say that you're not handling it (by passing it to the next responder) while ALSO handling it :) > Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:277 > + [self.nextResponder tryToPerform:_cmd with:sender]; (and here)
Created attachment 435197 [details] Patch
Comment on attachment 435197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435197&action=review > LayoutTests/fast/scrolling/keyboard-scrolling-distance-pageDown.html:1 > +<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true EventHandlerDrivenSmoothKeyboardScrollingEnabled=true ] --> Should wait and see if these actually pass on iOS (on the bots). I am hopeful but not certain :) > LayoutTests/fast/scrolling/keyboard-scrolling-distance-pageDown.html:38 > + dist: 0 WebKit style generally prefers not abbreviating things (I guess this is `distance`?) > LayoutTests/fast/scrolling/keyboard-scrolling-distance-pageDown.html:42 > + checkSuccessfulScroll(scrollObj) missing semicolon (not required, just a good habit)
Created attachment 435310 [details] Patch
Committed r280928 (240446@main): <https://commits.webkit.org/240446@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435310 [details].