spacebar and spacebar+shift do not case any movement
<rdar://problem/80911775>
Created attachment 434224 [details] Patch
Created attachment 434226 [details] Patch
Comment on attachment 434226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434226&action=review > Source/WebCore/platform/KeyboardScrollingAnimator.cpp:237 > - if (event.type() != eventNames().keydownEvent) > + if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent)) Hmm, I'm not sure this is right. Are you not getting `keydown` for the spacebar? If not, you probably want to figure out who is eating it.
Comment on attachment 434226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434226&action=review >> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:237 >> + if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent)) > > Hmm, I'm not sure this is right. Are you not getting `keydown` for the spacebar? If not, you probably want to figure out who is eating it. I guess it's OK (a bit weird, but existing weirdness); EventHandler::defaultSpaceEventHandler itself asserts it's only called with keypress, and the other callers of this call it explicitly only for keydown, so we won't get duplicates.
Can't cq+ this till the other patch lands :)
Created attachment 434453 [details] Patch
Committed r280501 (240133@main): <https://commits.webkit.org/240133@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434453 [details].