Bug 228151 - REGRESSION (r278916): Hitting ASSERT(!m_db.m_transactionInProgress) in SQLiteTransaction::begin()
Summary: REGRESSION (r278916): Hitting ASSERT(!m_db.m_transactionInProgress) in SQLite...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-21 09:55 PDT by Chris Dumez
Modified: 2021-07-21 13:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (63.53 KB, patch)
2021-07-21 10:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-07-21 09:55:51 PDT 
* thread #6, queue = 'WebResourceLoadStatisticsStore Process Data Queue', stop reason = EXC_BAD_ACCESS (code=1, address=0xbbadbeef)
  * frame #0: 0x00000001346c827e JavaScriptCore`::WTFCrash() at Assertions.cpp:321:35
    frame #1: 0x0000000119d4185b WebCore`WTFCrashWithInfo((null)=53, (null)="./platform/sql/SQLiteTransaction.cpp", (null)="void WebCore::SQLiteTransaction::begin()", (null)=433) at Assertions.h:697:5
    frame #2: 0x000000011e43984a WebCore`WebCore::SQLiteTransaction::begin(this=0x000070000e6382e8) at SQLiteTransaction.cpp:53:9
    frame #3: 0x0000000109449d6a WebKit`WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction(this=0x0000000107fc3000, domain=0x00000001417f8148, completionHandler=0x000070000e638338)>&&) at ResourceLoadStatisticsDatabaseStore.cpp:1906:17
    frame #4: 0x000000010944fa41 WebKit`WebKit::ResourceLoadStatisticsDatabaseStore::hasHadUnexpiredRecentUserInteraction(this=0x0000000107fc3000, resourceStatistic=0x00000001417f8140, operatingDatesWindow=Long) at ResourceLoadStatisticsDatabaseStore.cpp:2635:13
    frame #5: 0x000000010944faf7 WebKit`WebKit::ResourceLoadStatisticsDatabaseStore::shouldRemoveAllWebsiteDataFor(this=0x0000000107fc3000, resourceStatistic=0x00000001417f8140, shouldCheckForGrandfathering=false) at ResourceLoadStatisticsDatabaseStore.cpp:2645:73
    frame #6: 0x00000001094500f7 WebKit`WebKit::ResourceLoadStatisticsDatabaseStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor(this=0x0000000107fc3000) at ResourceLoadStatisticsDatabaseStore.cpp:2715:13
    frame #7: 0x0000000109462f4a WebKit`WebKit::ResourceLoadStatisticsStore::removeDataRecords(this=0x0000000107fc3000, completionHandler=0x000070000e638728)>&&) at ResourceLoadStatisticsStore.cpp:172:52
    frame #8: 0x0000000109463baa WebKit`WebKit::ResourceLoadStatisticsStore::processStatisticsAndDataRecords(this=0x0000000107fc3000) at ResourceLoadStatisticsStore.cpp:221:5
    frame #9: 0x00000001094d1d91 WebKit`WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated(this=0x0000000141c09468)>&&)::$_60::operator()() at WebResourceLoadStatisticsStore.cpp:375:28
    frame #10: 0x00000001094d1a8e WebKit`WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated(WTF::Vector<WebCore::ResourceLoadStatistics, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&, WTF::CompletionHandler<void ()>&&)::$_60, void>::call(this=0x0000000141c09460) at Function.h:53:39
    frame #11: 0x00000001085c01c2 WebKit`WTF::Function<void ()>::operator(this=0x000000014181e238)() const at Function.h:82:35
    frame #12: 0x000000010948078e WebKit`WebKit::WebResourceLoadStatisticsStore::postTask(this=0x000000014181e230)>&&)::'lambda'()::operator()() const at WebResourceLoadStatisticsStore.cpp:215:9
    frame #13: 0x00000001094805de WebKit`WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'(), void>::call(this=0x000000014181e228) at Function.h:53:39
    frame #14: 0x00000001346f2c92 JavaScriptCore`WTF::Function<void ()>::operator(this=0x00000001420f79e8)() const at Function.h:82:35
    frame #15: 0x0000000134806eae JavaScriptCore`WTF::(anonymous namespace)::DispatchWorkItem::operator(this=0x00000001420f79e0)() at WorkQueueCocoa.cpp:40:25
    frame #16: 0x000000013480602d JavaScriptCore`void WTF::dispatchWorkItem<WTF::(anonymous namespace)::DispatchWorkItem>(dispatchContext=0x00000001420f79e0) at WorkQueueCocoa.cpp:48:5
    frame #17: 0x00000001011f4274 libdispatch.dylib`_dispatch_client_callout + 8
    frame #18: 0x00000001011fb7f7 libdispatch.dylib`_dispatch_lane_serial_drain + 776
    frame #19: 0x00000001011fc6ca libdispatch.dylib`_dispatch_lane_invoke + 440
    frame #20: 0x000000010120a2d4 libdispatch.dylib`_dispatch_workloop_worker_thread + 1660
    frame #21: 0x0000000101296b68 libsystem_pthread.dylib`_pthread_wqthread + 314
    frame #22: 0x0000000101295b3f libsystem_pthread.dylib`start_wqthread + 15
Comment 1 Chris Dumez 2021-07-21 09:56:06 PDT 
<rdar://80231894>
Comment 2 Chris Dumez 2021-07-21 10:00:52 PDT 
Created attachment 433941 [details]
Patch
Comment 3 Geoffrey Garen 2021-07-21 12:53:01 PDT 
Comment on attachment 433941 [details]
Patch

r=me

I like it!
Comment 4 EWS 2021-07-21 13:29:21 PDT 
Committed r280157 (239854@main): <https://commits.webkit.org/239854@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433941 [details].