Bug 228148 - RunningBoard kills the network process if it is still holding the "holding locked file" assertion upon suspension
Summary: RunningBoard kills the network process if it is still holding the "holding lo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-21 08:22 PDT by Chris Dumez
Modified: 2021-07-21 14:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2021-07-21 08:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.03 KB, patch)
2021-07-21 11:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2021-07-21 12:31 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.87 KB, patch)
2021-07-21 12:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-07-21 08:22:59 PDT 
The network process should release its FinishTaskUninterruptable assertion when it expires or RunningBoard will kill the process. Note that because the process assertion is released on a hysteresis timer, there are 2 possible cases:
1. The network process is no longer holding locked files, we'll release the assertion and suspend nicely.
2. The network process is still holding locked files despite our best efforts, we'll release the assertion and crash on suspension due to holding locked files.
Comment 1 Chris Dumez 2021-07-21 08:24:50 PDT 
Created attachment 433935 [details]
Patch
Comment 2 Chris Dumez 2021-07-21 11:13:56 PDT 
Created attachment 433944 [details]
Patch
Comment 3 Chris Dumez 2021-07-21 12:31:40 PDT 
Created attachment 433947 [details]
Patch
Comment 4 Chris Dumez 2021-07-21 12:55:57 PDT 
Created attachment 433949 [details]
Patch
Comment 5 EWS 2021-07-21 13:59:34 PDT 
Committed r280160 (239857@main): <https://commits.webkit.org/239857@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433949 [details].
Comment 6 Radar WebKit Bug Importer 2021-07-21 14:00:20 PDT 
<rdar://problem/80916330>