Bug 228145 - REGRESSION (r280077): [GTK] Theme scrollbar css is no longer respected
Summary: REGRESSION (r280077): [GTK] Theme scrollbar css is no longer respected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alice Mikhaylenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-21 07:01 PDT by Jim Mason
Modified: 2021-07-21 08:32 PDT (History)
3 users (show)

See Also:

Attachments
Screenshot: scrollbar after r280077 (13.79 KB, image/png)
2021-07-21 07:06 PDT, Jim Mason 		no flags Details
Screenshot: Expected scrollbar with change reverted (13.33 KB, image/png)
2021-07-21 07:07 PDT, Jim Mason 		no flags Details
Patch (1.58 KB, patch)
2021-07-21 07:12 PDT, Alice Mikhaylenko 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Mason 2021-07-21 07:01:50 PDT 
GTK 3.24.23

It seems this change broke scrollbar theming in non-Adwaita themes.  Reverting the change restores the functionality.

There might be other UI elements similarly affected.

You should be able to reproduce with any theme, but for reference, I am using this one:  https://github.com/RocketMan/Solaris-11
Comment 1 Jim Mason 2021-07-21 07:06:14 PDT 
Created attachment 433931 [details]
Screenshot: scrollbar after r280077
Comment 2 Jim Mason 2021-07-21 07:07:06 PDT 
Created attachment 433932 [details]
Screenshot: Expected scrollbar with change reverted
Comment 3 Alice Mikhaylenko 2021-07-21 07:12:59 PDT 
Created attachment 433933 [details]
Patch
Comment 4 Alice Mikhaylenko 2021-07-21 07:14:13 PDT 
Note that as soon as we migrate to GTK4 the theme won't be used anyway - there's no way to foreign draw scrollbars. In fact, for 41 we'll likely default to custom drawn scrollbars at least for Adwaita, so that we can use dark scrollbars when possible - another thing not possible with themes. For now though it was just a typo.
Comment 5 Jim Mason 2021-07-21 07:27:41 PDT 
(In reply to Alexander Mikhaylenko from comment #3)
> Created attachment 433933 [details]
> Patch

This has to be the fastest fix ever.  Thank you!  I am building now to validate.
Comment 6 Jim Mason 2021-07-21 07:51:45 PDT 
Confirmed, the patch resolves the issue for me.  Thanks again.
Comment 7 EWS 2021-07-21 08:32:38 PDT 
Committed r280140 (239841@main): <https://commits.webkit.org/239841@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433933 [details].