Bug 228134 - Crash in -[WKWebView takeSnapshotWithConfiguration:completionHandler:] when taking empty snapshots
Summary: Crash in -[WKWebView takeSnapshotWithConfiguration:completionHandler:] when t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-20 18:19 PDT by Aditya Keerthi
Modified: 2021-07-21 14:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.15 KB, patch)
2021-07-20 18:20 PDT, Aditya Keerthi 		cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (6.16 KB, patch)
2021-07-21 08:44 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-07-20 18:19:08 PDT 
SSIA
Comment 1 Aditya Keerthi 2021-07-20 18:19:23 PDT 
rdar://80146087
Comment 2 Aditya Keerthi 2021-07-20 18:20:54 PDT 
Created attachment 433914 [details]
Patch
Comment 3 Chris Dumez 2021-07-21 08:28:33 PDT 
Comment on attachment 433914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433914&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1179
> +        RunLoop::main().dispatch([handler] {

handler = WTFMove(handler) to avoid refcounting churn.
Comment 4 Aditya Keerthi 2021-07-21 08:44:32 PDT 
Created attachment 433936 [details]
Patch for landing
Comment 5 EWS 2021-07-21 11:11:33 PDT 
Committed r280151 (239848@main): <https://commits.webkit.org/239848@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433936 [details].