Bug 228132 - Make the 'targetElement' argument of the SVG animators to be a reference
Summary: Make the 'targetElement' argument of the SVG animators to be a reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-20 16:24 PDT by Said Abou-Hallawa
Modified: 2021-07-20 20:34 PDT (History)
12 users (show)

See Also:

Attachments
Patch (69.44 KB, patch)
2021-07-20 16:31 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-07-20 16:24:22 PDT 
It is clear that many SVG animators functions assume the argument 'targetElement' is not nullptr. Also the caller SVGAnimateElementBase makes sure its targetElement() is not nullptr before calling any of its animator's functions.
Comment 1 Said Abou-Hallawa 2021-07-20 16:31:10 PDT 
Created attachment 433907 [details]
Patch
Comment 2 Cameron McCormack (:heycam) 2021-07-20 17:27:14 PDT 
Comment on attachment 433907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433907&action=review

Non-reviewer's r=me.

> Source/WebCore/svg/SVGElement.cpp:580
> +        propertyRegistry().setAnimatedPropertyDirty(attributeName, animatedProperty);

(Probably should have been in a separate patch.)
Comment 3 EWS 2021-07-20 20:33:51 PDT 
Committed r280123 (239835@main): <https://commits.webkit.org/239835@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433907 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-20 20:34:18 PDT 
<rdar://problem/80874381>