Currently, makeprop.pl has my %resolverKinds = ( "logical" => { "block" => "axis", "inline" => "axis", "block-start" => "side", "block-end" => "side", "inline-start" => "side", "inline-end" => "side", "start-start" => "corner", "start-end" => "corner", "end-start" => "corner", "end-end" => "corner", }, "physical" => { "horizontal" => "axis", "vertical" => "axis", "top" => "side", "right" => "side", "bottom" => "side", "left" => "side", "top-left" => "corner", "top-right" => "corner", "bottom-right" => "corner", "bottom-left" => "corner", }, ); So many repeated values, it would be better to structure it like: my %logicalPropertyResolvers = ( "logical" => { "axis" => ["inline", "block"], "side" => ["block-start", "inline-end", "block-end", "inline-start"], "corner" => ["start-start", "start-end", "end-start", "end-end"], }, "physical" => { "axis" => ["horizontal", "vertical"], "side" => ["top", "right", "bottom", "left"], "corner" => ["top-left", "top-right", "bottom-right", "bottom-left"], }, ); And this would avoid having to hardcode the lists in this other piece of code: if ($kind eq "side") { @physicals = ("top", "right", "bottom", "left"); } elsif ($kind eq "corner") { @physicals = ("top-left", "top-right", "bottom-right", "bottom-left"); } elsif ($kind eq "axis") { @physicals = ("horizontal", "vertical"); }
Created attachment 433905 [details] Patch
<rdar://problem/81187057>
Created attachment 449343 [details] Patch
Antti, can you take a look? Not urgent.
Comment on attachment 449343 [details] Patch rs=me
Committed r288114 (246128@main): <https://commits.webkit.org/246128@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449343 [details].