Bug 228106 - [GStreamer] Switch raw GstStructure pointers to GUniquePtr
Summary: [GStreamer] Switch raw GstStructure pointers to GUniquePtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-20 05:47 PDT by Philippe Normand
Modified: 2021-07-20 08:30 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2021-07-20 06:33 PDT, Philippe Normand 		calvaris: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-07-20 05:47:36 PDT 
SSIA
Comment 1 Philippe Normand 2021-07-20 06:33:15 PDT 
Created attachment 433872 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2021-07-20 07:34:32 PDT 
Comment on attachment 433872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433872&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2399
> +        m_mediaLocationCurrentIndex = static_cast<int>(gst_value_list_get_size(locations)) -1;

Now that we're changing this line, let's fix that - 1 .
Comment 3 Philippe Normand 2021-07-20 08:29:49 PDT 
Committed r280080 (239806@main): <https://commits.webkit.org/239806@main>
Comment 4 Radar WebKit Bug Importer 2021-07-20 08:30:17 PDT 
<rdar://problem/80840075>