Bug 228099 - Use references instead of pointers in WidthIterator::advanceInternal()
Summary: Use references instead of pointers in WidthIterator::advanceInternal()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-19 23:41 PDT by Myles C. Maxfield
Modified: 2021-07-20 13:41 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.50 KB, patch)
2021-07-19 23:42 PDT, Myles C. Maxfield
Hironori.Fujii: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-07-19 23:41:26 PDT
Use references instead of pointers in WidthIterator::advanceInternal()
Comment 1 Myles C. Maxfield 2021-07-19 23:42:22 PDT
Created attachment 433852 [details]
Patch
Comment 2 Fujii Hironori 2021-07-20 13:23:30 PDT
Comment on attachment 433852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433852&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:237
> +        ASSERT(&font);

This ASSERT doesn't looks useful. I think you should remove this ASSERT.
Comment 3 Myles C. Maxfield 2021-07-20 13:39:59 PDT
Thanks for the review!!!
Comment 4 Myles C. Maxfield 2021-07-20 13:40:25 PDT
Committed r280102 (239819@main): <https://commits.webkit.org/239819@main>
Comment 5 Radar WebKit Bug Importer 2021-07-20 13:41:16 PDT
<rdar://problem/80855739>