RESOLVED FIXED 228099
Use references instead of pointers in WidthIterator::advanceInternal() 
https://bugs.webkit.org/show_bug.cgi?id=228099
Summary Use references instead of pointers in WidthIterator::advanceInternal()
Myles C. Maxfield
Reported 2021-07-19 23:41:26 PDT
Use references instead of pointers in WidthIterator::advanceInternal()
Attachments
Patch (3.50 KB, patch)
2021-07-19 23:42 PDT, Myles C. Maxfield 		Hironori.Fujii: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-07-19 23:42:22 PDT
Created attachment 433852 [details] Patch
Fujii Hironori
Comment 2 2021-07-20 13:23:30 PDT
Comment on attachment 433852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433852&action=review > Source/WebCore/platform/graphics/WidthIterator.cpp:237 > + ASSERT(&font); This ASSERT doesn't looks useful. I think you should remove this ASSERT.
Myles C. Maxfield
Comment 3 2021-07-20 13:39:59 PDT
Thanks for the review!!!
Myles C. Maxfield
Comment 4 2021-07-20 13:40:25 PDT
Committed r280102 (239819@main): <https://commits.webkit.org/239819@main>
Radar WebKit Bug Importer
Comment 5 2021-07-20 13:41:16 PDT
<rdar://problem/80855739>
Note You need to log in before you can comment on or make changes to this bug.