Bug 228086 - [iOS] Tapping images on twitter.com should not toggle tab bar visibility
Summary: [iOS] Tapping images on twitter.com should not toggle tab bar visibility
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-19 13:34 PDT by Wenson Hsieh
Modified: 2021-07-19 17:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.11 KB, patch)
2021-07-19 14:52 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-07-19 13:34:58 PDT 
rdar://79667219
Comment 1 Wenson Hsieh 2021-07-19 14:52:49 PDT 
Created attachment 433824 [details]
Patch
Comment 2 Geoffrey Garen 2021-07-19 15:07:34 PDT 
Comment on attachment 433824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433824&action=review

> Source/WebKit/ChangeLog:9
> +        Treat taps over elements that are explicitly marked draggable and also respond to click events as "meaningful"

Is the "and also respond to click events" detail in this patch, or in pre-existing code?
Comment 3 Wenson Hsieh 2021-07-19 15:09:16 PDT 
Comment on attachment 433824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433824&action=review

>> Source/WebKit/ChangeLog:9
>> +        Treat taps over elements that are explicitly marked draggable and also respond to click events as "meaningful"
> 
> Is the "and also respond to click events" detail in this patch, or in pre-existing code?

Ah, so this is in pre-existing code (more specifically, the `clickNode` that's passed in is a `nodeRespondingToClickEvents`).
Comment 4 Geoffrey Garen 2021-07-19 15:09:56 PDT 
Comment on attachment 433824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433824&action=review

r=me

>> Source/WebKit/ChangeLog:9
>> +        Treat taps over elements that are explicitly marked draggable and also respond to click events as "meaningful"
> 
> Is the "and also respond to click events" detail in this patch, or in pre-existing code?

I see: The caller ensures nodeRespondingToClickEvents().
Comment 5 Wenson Hsieh 2021-07-19 16:43:15 PDT 
Comment on attachment 433824 [details]
Patch

Thanks for the review!
Comment 6 EWS 2021-07-19 17:00:23 PDT 
Committed r280057 (239792@main): <https://commits.webkit.org/239792@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433824 [details].