Bug 228085 – FetchResponse.formData() should not reject promise if the body is null and the MIME Type is "application/x-www-form-urlencoded"

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

FetchResponse.formData() should not reject promise if the body is null and the MIME Type is "application/x-www-form-urlencoded":
- https://fetch.spec.whatwg.org/#concept-body-consume-body
- https://fetch.spec.whatwg.org/#concept-body-package-data

As per the specification, we should package an empty byte sequence in this case and resolve the promise with that.

[Chris Dumez]

Created attachment 433813 [details]
Patch

[Chris Dumez]

Created attachment 433814 [details]
Patch

[Alex Christensen]

Comment on attachment 433814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433814&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:195
> +    if (isBodyNullOrOpaque()) {
> +        // If the content-type is 'application/x-www-form-urlencoded', a body is not required and we should package an empty byte sequence as per the specification.

It seems like we should only do this for isBodyNull

[Chris Dumez]

Created attachment 433815 [details]
Patch

[Chris Dumez]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 433814 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=433814&action=review
> 
> > Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:195
> > +    if (isBodyNullOrOpaque()) {
> > +        // If the content-type is 'application/x-www-form-urlencoded', a body is not required and we should package an empty byte sequence as per the specification.
> 
> It seems like we should only do this for isBodyNull

Good point, the spec only mentions the body being null.

[Chris Dumez]

Why the r-??

[Alex Christensen]

isBodyNullOrOpaque needs to be changed to isBodyNull

[Chris Dumez]

Comment on attachment 433815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433815&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:195
> +        if (isBodyNull()) {

It does check isBodyNull()... ?

[Alex Christensen]

Comment on attachment 433815 [details]
Patch

Oh, I didn't see that there was a new patch.  Sorry

[EWS]

Committed r280046 (239781@main): <https://commits.webkit.org/239781@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433815 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80802980>