Bug 228077 – [GTK][WPE] fix compilation when ATK is not used

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Víctor M. Jáquez L.]

When compiling in embedded environment I get this error:

In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-7.cpp:8:
Source/WebKit/UIProcess/WebPageProxy.cpp: In member function ‘void WebKit::WebPageProxy::swapToProvisionalPage(std::unique_ptr<WebKit::ProvisionalPageProxy>)’:
Source/WebKit/UIProcess/WebPageProxy.cpp:975:9: error: ‘bindAccessibilityTree’ was not declared in this scope
  975 |         bindAccessibilityTree(accessibilityPlugID);
      |         ^~~~~~~~~~~~~~~~~~~~~

It seems r279983 introduced this regression.

[Víctor M. Jáquez L.]

Created attachment 433783 [details]
Patch

[Carlos Garcia Campos]

Right, this is because I changed this in a local branch and I forgot about it. Could you change the ATK ifdef in WebPageProxy.messages.in to PLATFORM GTK or WPE and in WebPageProxyWPE.cpp move the ATK ifdef inside the bindAccessibilityTree() function?

[Víctor M. Jáquez L.]

Created attachment 433789 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 433789 [details]
Patch

Thanks!

[EWS]

[e-mail] does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 433789 [details] from commit queue.

[Carlos Garcia Campos]

Comment on attachment 433789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433789&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:2225
> +#if USE(ATK)
>      void showEmojiPicker(const WebCore::IntRect&, CompletionHandler<void(String)>&&);
>  #endif

Wait. I didn't notice this. It's an existing issue, but we can fix it now that we are changing it. This should the PLATFORM(GTK) since the emoji picker is GTK specific, it has nothing to do with ATK

[Víctor M. Jáquez L.]

Created attachment 433858 [details]
Patch

[EWS]

[e-mail] does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 433858 [details] from commit queue.

[Víctor M. Jáquez L.]

Comment on attachment 433858 [details]
Patch

It seems I forgot a step while re-enabling my committer status :S 

In the meanwhile, Carlos, can you pull the commit-queue knob?

[EWS]

Committed r280074 (239800@main): <https://commits.webkit.org/239800@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433858 [details].