RESOLVED LATER Bug 22806
New test to verify that cached page with a timer releases JS references on cache purge 
https://bugs.webkit.org/show_bug.cgi?id=22806
Summary New test to verify that cached page with a timer releases JS references on ca...
Dmitry Titov
Reported 2008-12-11 00:55:02 PST
This is a test for bug 22753. It needs the patch for the bug 20534 to be landed to enable page cache in DumpRenderTree.
Attachments
Proposed patch (5.44 KB, patch)
2008-12-11 01:01 PST, Dmitry Titov 		no flags
DetailsFormatted DiffDiff
patch v2 (5.36 KB, patch)
2008-12-11 18:40 PST, Dmitry Titov 		darin: review+
DetailsFormatted DiffDiff
Revert the landing (5.34 KB, patch)
2009-02-04 18:27 PST, Dmitry Titov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2008-12-11 01:01:16 PST
Created attachment 25943 [details] Proposed patch Not r? yet because it waits for enabling patch for bug 20534 to be landed.
Dmitry Titov
Comment 2 2008-12-11 14:19:47 PST
Comment on attachment 25943 [details] Proposed patch The blocking change is in. Flipping the review bit after verifying the test.
Dmitry Titov
Comment 3 2008-12-11 15:44:08 PST
Comment on attachment 25943 [details] Proposed patch slightly updated patch on its way, removing r? for now.
Dmitry Titov
Comment 4 2008-12-11 18:40:24 PST
Created attachment 25972 [details] patch v2 I've removed the printing of the getJSObjectCount output - due to unrelated changes, this can slightly change and make test fail :-)
Darin Adler
Comment 5 2008-12-12 10:11:37 PST
Comment on attachment 25972 [details] patch v2 > \ No newline at end of file > \ No newline at end of file > \ No newline at end of file We prefer to put newlines at the ends of files. r=me
Dmitry Titov
Comment 6 2008-12-12 10:24:07 PST
The bug 20534 that enables DRT page cache was reverted and reopened. So this test won't run correctly if landed now. Please don't land for now.
Eric Seidel (no email)
Comment 7 2009-02-04 15:48:33 PST
Dimitri should soon have commit bit (just waiting for infos from teh Apple), but I'll commit this now anyway.
Eric Seidel (no email)
Comment 8 2009-02-04 15:56:56 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/dom/Window/cached-timeout-stopped-on-close-expected.txt A LayoutTests/fast/dom/Window/cached-timeout-stopped-on-close.html A LayoutTests/fast/dom/Window/resources/cached-timeout-page-1.html A LayoutTests/fast/dom/Window/resources/cached-timeout-page-2.html Committed r40639
Dmitry Titov
Comment 9 2009-02-04 18:20:00 PST
This test should not have been committed yet :-( It depends on bug 20534 which is not yet landed.
Dmitry Titov
Comment 10 2009-02-04 18:27:52 PST
Created attachment 27338 [details] Revert the landing The revert patch.
Dmitry Titov
Comment 11 2009-02-04 20:43:06 PST
Resolving as LATER to remove it from the landing queue.
Dimitri Glazkov (Google)
Comment 12 2009-02-04 20:44:34 PST
Reverted in http://trac.webkit.org/changeset/40661.
Note You need to log in before you can comment on or make changes to this bug.