Bug 228058 – Fix canvas overflow checking to use CheckedArithmatic rather than adhoc floating point mechanism

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Fix canvas overflow checking to use CheckedArithmatic rather than adhoc floating point mechanism

[Sam Weinig]

Created attachment 433750 [details]
Patch

[EWS]

Committed r280020 (239762@main): <https://commits.webkit.org/239762@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433750 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80748974>

[Said Abou-Hallawa]

Comment on attachment 433750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433750&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:879
>  #if USE(IOSURFACE_CANVAS_BACKING_STORE)

Should not this #if be moved to the beginning of the function since #if USE(IOSURFACE_CANVAS_BACKING_STORE) is false, we are going to return false always?

[Sam Weinig]

Comment on attachment 433750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433750&action=review

>> Source/WebCore/html/HTMLCanvasElement.cpp:879
>>  #if USE(IOSURFACE_CANVAS_BACKING_STORE)
> 
> Should not this #if be moved to the beginning of the function since #if USE(IOSURFACE_CANVAS_BACKING_STORE) is false, we are going to return false always?

Sure, though that seems unrelated to the change. Seems like a fine change. If I was changing something like that, I would probably also add a better macro for this that isn't platform specific.