Bug 228044 - Network access prevention SPI should prevent preconnecting, and it should first allow injected bundle to change request
Summary: Network access prevention SPI should prevent preconnecting, and it should fir...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 227992 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-07-16 17:12 PDT by Alex Christensen
Modified: 2021-07-19 10:28 PDT (History)
6 users (show)

See Also:


Attachments
Patch (17.74 KB, patch)
2021-07-16 17:17 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (16.09 KB, patch)
2021-07-16 17:19 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-07-16 17:12:31 PDT
Network access prevention SPI should prevent preconnecting, and it should first allow injected bundle to change request
Comment 1 Alex Christensen 2021-07-16 17:17:18 PDT
Created attachment 433717 [details]
Patch
Comment 2 Alex Christensen 2021-07-16 17:17:21 PDT
<rdar://problem/72995136>
Comment 3 Alex Christensen 2021-07-16 17:19:49 PDT
Created attachment 433718 [details]
Patch
Comment 4 Alex Christensen 2021-07-16 17:21:26 PDT
*** Bug 227992 has been marked as a duplicate of this bug. ***
Comment 5 Tim Horton 2021-07-16 17:45:43 PDT
Comment on attachment 433718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433718&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SchemeChangingPlugIn.mm:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2021!
Comment 6 Tim Horton 2021-07-16 17:46:08 PDT
Does seem reasonable and non-harmful, but because it's loader code it would really be good to make Brady look too!
Comment 7 Alex Christensen 2021-07-16 18:00:32 PDT
http://trac.webkit.org/r280014
Comment 8 Geoffrey Garen 2021-07-19 10:28:07 PDT
Nice!