Bug 228040 – [JSC] Simplify sampling-profiler-regexp.js test

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Simplify sampling-profiler-regexp.js test

[Yusuke Suzuki]

Created attachment 433712 [details]
Patch

[Saam Barati]

Comment on attachment 433712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433712&action=review

> JSTests/stress/sampling-profiler/samplingProfiler.js:37
> +const VERBOSE = true;

id you want to check this part in?

> JSTests/stress/sampling-profiler/samplingProfiler.js:69
>      if (isRunFromRunTest)
> -        stackTrace = [...stackTrace, "runTest", "(program)"];
> +        stackTrace = [...stackTraceOrString, "runTest", "(program)"];
>      else
> -        stackTrace = [...stackTrace];
> +        stackTrace = [...stackTraceOrString];

does this make sense if the stack trace is a string?

[Yusuke Suzuki]

Comment on attachment 433712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433712&action=review

>> JSTests/stress/sampling-profiler/samplingProfiler.js:37
>> +const VERBOSE = true;
> 
> id you want to check this part in?

Oops! Nice catch. We should make it false.

>> JSTests/stress/sampling-profiler/samplingProfiler.js:69
>> +        stackTrace = [...stackTraceOrString];
> 
> does this make sense if the stack trace is a string?

We have `if (typeof stackTraceOrString === 'string') {` branch before this :)

[Yusuke Suzuki]

Created attachment 433713 [details]
Patch

[Saam Barati]

Comment on attachment 433712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433712&action=review

>>> JSTests/stress/sampling-profiler/samplingProfiler.js:37
>>> +const VERBOSE = true;
>> 
>> id you want to check this part in?
> 
> Oops! Nice catch. We should make it false.

👍
(I meant to write "did" for the first word here)

>>> JSTests/stress/sampling-profiler/samplingProfiler.js:69
>>> +        stackTrace = [...stackTraceOrString];
>> 
>> does this make sense if the stack trace is a string?
> 
> We have `if (typeof stackTraceOrString === 'string') {` branch before this :)

👍

I missed that the above branch always returns.

[EWS]

Committed r280011 (239753@main): <https://commits.webkit.org/239753@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433713 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80709969>