Bug 22804 - Crash (null-deref) when using :before pseudoselector with content CSS rule in SVG
Summary: Crash (null-deref) when using :before pseudoselector with content CSS rule in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords: HasReduction, InRadar
Depends on:
Blocks:
 
Reported: 2008-12-10 22:58 PST by Oliver Hunt
Modified: 2008-12-11 14:34 PST (History)
0 users

See Also:


Attachments
Patch o' doom (4.68 KB, patch)
2008-12-10 22:58 PST, Oliver Hunt
adele: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2008-12-10 22:58:09 PST
CSS generated content results in a RenderObject with no element, causing SVG text layout and painting to crash and burn

<rdar://problem/6302405>
Comment 1 Oliver Hunt 2008-12-10 22:58:59 PST
Created attachment 25941 [details]
Patch o' doom

Fixeration
Comment 2 Adele Peterson 2008-12-11 01:44:03 PST
Comment on attachment 25941 [details]
Patch o' doom

R=me.  I assume the CL entries for Info.plist and the Xcode proj don't belong...
Comment 3 Oliver Hunt 2008-12-11 01:51:58 PST
(In reply to comment #2)
> (From update of attachment 25941 [details] [review])
> R=me.  I assume the CL entries for Info.plist and the Xcode proj don't
> belong...
> 

Yup *sigh*

Also, have better text in the test now -- says something akin to "This test ensures that we don't display css content or crash when css generated content is used"
Comment 4 Oliver Hunt 2008-12-11 14:34:16 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/svg/css/crash-css-generated-content-expected.txt
	A	LayoutTests/svg/css/crash-css-generated-content.xhtml
	M	WebCore/ChangeLog
	M	WebCore/rendering/SVGRootInlineBox.cpp
Committed r39218