Bug 228039 - PCM: Add early return when unlinkable token is used and add more happy path Web Inspector logging
Summary: PCM: Add early return when unlinkable token is used and add more happy path W...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-16 15:31 PDT by John Wilander
Modified: 2021-07-16 16:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.93 KB, patch)
2021-07-16 15:38 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2021-07-16 15:31:40 PDT 
We should do an early return when an accepted unlinkable token transaction is happening. We should also add more Web Inspector logging to the happy path for better developer feedback.
Comment 1 Radar WebKit Bug Importer 2021-07-16 15:32:06 PDT 
<rdar://problem/80705989>
Comment 2 John Wilander 2021-07-16 15:38:18 PDT 
Created attachment 433711 [details]
Patch
Comment 3 Kate Cheney 2021-07-16 16:18:43 PDT 
Comment on attachment 433711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433711&action=review

r=me

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:100
> +            return;

Nice catch.
Comment 4 John Wilander 2021-07-16 16:46:07 PDT 
Comment on attachment 433711 [details]
Patch

Thank you, Kate!
Comment 5 EWS 2021-07-16 16:53:31 PDT 
Committed r280009 (239751@main): <https://commits.webkit.org/239751@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433711 [details].