Bug 228028 - macOS Safari network sessions not being marked as being from a browser
Summary: macOS Safari network sessions not being marked as being from a browser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-16 10:34 PDT by Kate Cheney
Modified: 2021-07-16 14:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2021-07-16 10:42 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-07-16 10:34:38 PDT 
macOS Safari network sessions not being marked as being from a browser
Comment 1 Kate Cheney 2021-07-16 10:42:51 PDT 
Created attachment 433684 [details]
Patch
Comment 2 Brent Fulgham 2021-07-16 13:12:27 PDT 
Comment on attachment 433684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433684&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:-86
> -#define NETWORK_SESSION_COCOA_ADDITIONS_1

Always nice to see this stuff go away.
Comment 3 EWS 2021-07-16 14:26:21 PDT 
Committed r280001 (239743@main): <https://commits.webkit.org/239743@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433684 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-16 14:27:18 PDT Comment hidden (obsolete)
Comment 5 Kate Cheney 2021-07-16 14:28:42 PDT 
The correct radar is rdar://80648664