Bug 228026 - Web Inspector: propagate changes from `Page.overrideSetting` to the UIProcess
Summary: Web Inspector: propagate changes from `Page.overrideSetting` to the UIProcess
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-16 10:07 PDT by Devin Rousso
Modified: 2021-07-23 10:08 PDT (History)
17 users (show)

See Also:


Attachments
Patch (56.24 KB, patch)
2021-07-16 10:38 PDT, Devin Rousso
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (55.34 KB, patch)
2021-07-16 10:55 PDT, Devin Rousso
drousso: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-07-16 10:07:30 PDT
this would allow `WKWebView` clients to see whether Web Inspector has disabled various settings/preferences
Comment 1 Devin Rousso 2021-07-16 10:38:33 PDT
Created attachment 433683 [details]
Patch
Comment 2 Wenson Hsieh 2021-07-16 10:46:54 PDT
Comment on attachment 433683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433683&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:794
> +    bool shouldAlwaysUseMaximumObscuredInsets() const { return m_shouldAlwaysUseMaximumObscuredInsets; }
> +    void setShouldAlwaysUseMaximumObscuredInsets(bool);

This looks unused.
Comment 3 Devin Rousso 2021-07-16 10:50:18 PDT
Comment on attachment 433683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433683&action=review

>> Source/WebKit/UIProcess/WebPageProxy.h:794
>> +    void setShouldAlwaysUseMaximumObscuredInsets(bool);
> 
> This looks unused.

oops!  forgot to remove old code 😅
Comment 4 Devin Rousso 2021-07-16 10:55:34 PDT
Created attachment 433686 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-07-23 10:08:14 PDT
<rdar://problem/81023726>