Bug 228022 – Images as grid items should use the overridingLogicalWidth when defined to compute the logical Height

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

RenderReplaced as grid items should use the overridingLogicalWidth when defined to compute the logical height.

Created attachment 433673 [details]
Patch

[Javier Fernandez]

Comment on attachment 433673 [details]
Patch

r=me

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 433673 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Created attachment 433795 [details]
Patch

[EWS]

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Created attachment 433854 [details]
Patch

[EWS]

Committed r280078 (239804@main): <https://commits.webkit.org/239804@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433854 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80831713>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/280078/webkit

broke fast/images/exif-orientation-composited.html on windows 

history:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fimages%2Fexif-orientation-composited.html

Diff:
https://ews-build.s3-us-west-2.amazonaws.com/Windows-EWS/r433795-100045/fast/images/exif-orientation-composited-diffs.html

It looks like the test is no longer outputting some text.

[Truitt Savell]

This is affecting windows EWS badly so we will need a fix or to revert this change.

Created attachment 434277 [details]
Patch

Created attachment 434279 [details]
Patch

(In reply to Truitt Savell from comment #9)
> It looks like the changes in https://trac.webkit.org/changeset/280078/webkit
> 
> broke fast/images/exif-orientation-composited.html on windows 
> 
> history:
> https://results.webkit.org/?suite=layout-tests&test=fast%2Fimages%2Fexif-
> orientation-composited.html
> 
> Diff:
> https://ews-build.s3-us-west-2.amazonaws.com/Windows-EWS/r433795-100045/fast/
> images/exif-orientation-composited-diffs.html
> 
> It looks like the test is no longer outputting some text.

Thank you. This is addressed at Bug 228325.

Created attachment 444373 [details]
Patch

[Javier Fernandez]

Comment on attachment 444373 [details]
Patch

r=me 

The changes looks good; it seems the only difference with the version we had landed is that now the caller is the grid item, as it should have been. 

However, I wonder whether we need also the lines removed in the patch to fix the bug #228325. Perhaps that regression was caused by the error we are fixing now in this patch, due to calling constrainLogicalWidthInFragmentByMinMax from the grid container .

[EWS]

Committed r285998 (244395@main): <https://commits.webkit.org/244395@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444373 [details].

*** Bug 228325 has been marked as a duplicate of this bug. ***

[Gabriel Nava Marino]

*** Bug 232922 has been marked as a duplicate of this bug. ***