Bug 228018 – [Cocoa] ".SF Arabic" should not be able to be looked up by name (because it is dot-prefixed)

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Ebrahim Byagowi]

Created attachment 433664 [details]
Arabic letters aren't connected

Steps:
0. Upgrade to macOS Monterey beta.
1.
data:text/html;charset=utf8,<b style="font-family:'.SF Arabic'">سیب
2. Use touchpad pinch to zoom to zoom on the text to show

Actual:
There is a space between Arabic letters

Expected:
To have all letters connected

[Ebrahim Byagowi]

There is a difference between these two,

data:text/html;charset=utf8,<b style="font-family:'.SF Arabic'">سیب

data:text/html;charset=utf8,<b style="font-family:system-ui">سیب

Their fonts are the same but getting bold in different ways, maybe somehow the disconnect letters is because of this

[Radar WebKit Bug Importer]

<rdar://problem/80691654>

[Myles C. Maxfield]

*** Bug 228163 has been marked as a duplicate of this bug. ***

[Myles C. Maxfield]

*** Bug 228163 has been marked as a duplicate of this bug. ***

[Myles C. Maxfield]

Created attachment 433954 [details]
Patch

[Myles C. Maxfield]

Created attachment 433975 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 433975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433975&action=review

Is it OK to do this on all OS versions?

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1114
> +        || equalLettersIgnoringASCIICase(family, ".sf arabic")) {

I would move this up to below ".sf ui mono"

[Myles C. Maxfield]

Committed r280201 (239889@main): <https://commits.webkit.org/239889@main>

[Myles C. Maxfield]

(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 433975 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=433975&action=review
> 
> Is it OK to do this on all OS versions?

SF Arabic is new to Monterey & iOS 15