Bug 228000 - [webkitscmpy] Provide API to access SVN cache
Summary: [webkitscmpy] Provide API to access SVN cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-15 12:43 PDT by Jonathan Bedard
Modified: 2021-07-16 11:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (20.37 KB, patch)
2021-07-15 12:46 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (21.18 KB, patch)
2021-07-16 10:12 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-07-15 12:43:04 PDT
We already have a cache of SVN revisions to identifiers, but we don't have an API for other tools to access this cache. We created an API for Git (https://bugs.webkit.org/show_bug.cgi?id=225616), and the same API mostly works for SVN. If we provided functions calls that matched what we do for git, we could unify log and blame code for both git and SVN.
Comment 1 Radar WebKit Bug Importer 2021-07-15 12:43:22 PDT
<rdar://problem/80646471>
Comment 2 Jonathan Bedard 2021-07-15 12:46:42 PDT
Created attachment 433612 [details]
Patch
Comment 3 dewei_zhu 2021-07-16 04:29:18 PDT
Comment on attachment 433612 [details]
Patch

r=me
Comment 4 Jonathan Bedard 2021-07-16 10:12:23 PDT
Created attachment 433682 [details]
Patch for landing
Comment 5 EWS 2021-07-16 11:18:12 PDT
Committed r279991 (239734@main): <https://commits.webkit.org/239734@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433682 [details].