Bug 22798 – Unitialized struct field in SVGFont.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Dave Moore]

In Font::drawTextUsingSVGFont() a variable of type SVGTextRunWalkerDrawTextData is created on the stack (called data). One of its fields, charsConsumed, is unitialized, leading to random values after calling walk() on the SVGTextRunWalker created with it.

Patch will be attached

[Dave Moore]

Created attachment 25926 [details]
Patch to fix

This patch adds initialization of the charsConsumed field

[Dave Moore]

Created attachment 25952 [details]
Patch to fix

[Eric Seidel (no email)]

Comment on attachment 25952 [details]
Patch to fix

Just nits:
 1 2008-12-11  davemoore  <[e-mail]>

Should be:
 1 2008-12-11  David Moore  <[e-mail]>

(See my email on changelog entries sent to chrome-team last week.)

WARNING: NO TEST CASES ADDED OR CHANGED

can be removed and replaced when an explanation as to why it's untestable.

 5 	Fixed https://bugs.webkit.org/show_bug.cgi?id=22798

Looks like a tab (or maybe just bad indentation)

Looks fine.  We could also have fixed this by adding a constructor to SVGTextRunWalkerMeasuredLengthData (which would have possibly prevented future such UMRs.


Marking r- for the nits.  Post another copy and I'll be happy to review and land it for you.  Thanks for the fix!

[Dave Moore]

Created attachment 25956 [details]
Patch to fix

Fixed review issues

[Eric Seidel (no email)]

Comment on attachment 25956 [details]
Patch to fix

Looks fine.

[Eric Seidel (no email)]

Only snag I hit was one tab in the ChangeLog (we have a pre-commit script which fails if tabs are in any file).  Otherwise the patch was great!

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/svg/SVGFont.cpp
Committed r39260