Bug 227979 - The fast text codepath does not handle run initial advances
Summary: The fast text codepath does not handle run initial advances
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 206208
  Show dependency treegraph
 
Reported: 2021-07-14 23:14 PDT by Myles C. Maxfield
Modified: 2021-08-19 21:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.26 KB, patch)
2021-07-14 23:15 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (18.98 KB, patch)
2021-07-14 23:29 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (28.41 KB, patch)
2021-07-19 23:34 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (25.36 KB, patch)
2021-07-25 16:58 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (25.33 KB, patch)
2021-07-25 17:08 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (27.45 KB, patch)
2021-07-25 18:49 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-07-14 23:14:51 PDT
The fast text codepath does not handle run initial advances
Comment 1 Myles C. Maxfield 2021-07-14 23:15:22 PDT
Created attachment 433562 [details]
Patch
Comment 2 Myles C. Maxfield 2021-07-14 23:15:43 PDT
Comment on attachment 433562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433562&action=review

> Source/WebCore/platform/graphics/ComplexTextController.cpp:725
> +                // FIXME: The initial advance needs to be added to the visually previous glyph's advance, not the current glyph's advance.

This might actually be false 🤔
Comment 3 Myles C. Maxfield 2021-07-14 23:29:40 PDT
Created attachment 433564 [details]
Patch
Comment 4 Myles C. Maxfield 2021-07-19 22:20:13 PDT
Comment on attachment 433562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433562&action=review

>> Source/WebCore/platform/graphics/ComplexTextController.cpp:725
>> +                // FIXME: The initial advance needs to be added to the visually previous glyph's advance, not the current glyph's advance.
> 
> This might actually be false 🤔

It isn't false.
Comment 5 Myles C. Maxfield 2021-07-19 23:34:24 PDT
Created attachment 433851 [details]
WIP
Comment 6 Radar WebKit Bug Importer 2021-07-21 23:15:17 PDT
<rdar://problem/80942757>
Comment 7 Myles C. Maxfield 2021-07-25 16:58:42 PDT
Created attachment 434184 [details]
Patch
Comment 8 Myles C. Maxfield 2021-07-25 17:08:37 PDT
Created attachment 434185 [details]
Patch
Comment 9 Myles C. Maxfield 2021-07-25 18:49:23 PDT
Created attachment 434188 [details]
Patch
Comment 10 EWS 2021-08-19 21:53:29 PDT
Committed r281294 (240718@main): <https://commits.webkit.org/240718@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434188 [details].