Bug 22796 - Rewrite animations layout tests to take advantage of pauseAnimationAtTimeOnElementWithId()
Summary: Rewrite animations layout tests to take advantage of pauseAnimationAtTimeOnEl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Pierre-Olivier Latour
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-10 14:00 PST by Pierre-Olivier Latour
Modified: 2008-12-10 16:48 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (60.74 KB, patch)
2008-12-10 15:09 PST, Pierre-Olivier Latour
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Olivier Latour 2008-12-10 14:00:50 PST
Rewrite animations layout tests to take advantage of the new DRT API: pauseAnimationAtTimeOnElementWithId()

Currently, many the animation tests measure CSS property values after a given elapsed time and they use setTimeout() a delay of about one second or more. This slows down the tests quite a bit, has imprecision problems (since you can't guarantee you're measuring at a precise time), and is not scalable overall.
Comment 1 Pierre-Olivier Latour 2008-12-10 15:09:21 PST
Created attachment 25927 [details]
Patch v1

Pre-reviewed by Chris Marrin

Running animations tests now takes around 5sec instead of +15secs
Comment 2 Darin Adler 2008-12-10 16:35:14 PST
Comment on attachment 25927 [details]
Patch v1

> Index: LayoutTests/platform/win/Skipped
> ===================================================================
> --- LayoutTests/platform/win/Skipped	(revision 39183)
> +++ LayoutTests/platform/win/Skipped	(working copy)
> @@ -445,6 +445,8 @@ http/tests/xmlhttprequest/upload-onprogr
>  # No transition / animation pause LayoutController API on Windows DRT (https://bugs.webkit.org/show_bug.cgi?id=22239)
>  animations/animation-drt-api.html
>  animations/animation-drt-api-multiple-keyframes.html
> +animations/keyframes-from-missing.html
> +animations/keyframes-to-missing.html
>  transitions/transition-drt-api.html
>  transitions/transition-drt-api-delay.html
>  transitions/transition-shorthand-delay.html

It's always sad to lose test coverage on Windows.

r=me
Comment 3 Pierre-Olivier Latour 2008-12-10 16:48:46 PST
Fixed a couple issues noticed by bdash and simon

Sending        LayoutTests/ChangeLog
Sending        LayoutTests/animations/animation-test-helpers.js
Sending        LayoutTests/animations/big-rotation-expected.txt
Sending        LayoutTests/animations/big-rotation.html
Sending        LayoutTests/animations/change-keyframes-expected.txt
Sending        LayoutTests/animations/change-keyframes-name-expected.txt
Sending        LayoutTests/animations/change-keyframes-name.html
Sending        LayoutTests/animations/change-keyframes.html
Sending        LayoutTests/animations/change-one-anim-expected.txt
Sending        LayoutTests/animations/change-one-anim.html
Sending        LayoutTests/animations/generic-from-to-expected.txt
Sending        LayoutTests/animations/generic-from-to.html
Sending        LayoutTests/animations/import-expected.txt
Sending        LayoutTests/animations/import.html
Sending        LayoutTests/animations/keyframe-timing-functions-expected.txt
Sending        LayoutTests/animations/keyframe-timing-functions.html
Sending        LayoutTests/animations/keyframes-comma-separated-expected.txt
Sending        LayoutTests/animations/keyframes-comma-separated.html
Sending        LayoutTests/animations/keyframes-expected.txt
Sending        LayoutTests/animations/keyframes-from-missing.html
Sending        LayoutTests/animations/keyframes-out-of-order-expected.txt
Sending        LayoutTests/animations/keyframes-out-of-order.html
Sending        LayoutTests/animations/keyframes-to-missing.html
Sending        LayoutTests/animations/keyframes.html
Sending        LayoutTests/animations/lineheight-animation-expected.txt
Sending        LayoutTests/animations/lineheight-animation.html
Sending        LayoutTests/animations/matrix-anim-expected.txt
Sending        LayoutTests/animations/matrix-anim.html
Sending        LayoutTests/animations/multiple-animations-expected.txt
Sending        LayoutTests/animations/multiple-animations.html
Sending        LayoutTests/animations/multiple-keyframes-expected.txt
Sending        LayoutTests/animations/multiple-keyframes.html
Sending        LayoutTests/animations/transition-and-animation-1-expected.txt
Sending        LayoutTests/animations/transition-and-animation-1.html
Sending        LayoutTests/animations/transition-and-animation-2-expected.txt
Sending        LayoutTests/animations/transition-and-animation-2.html
Sending        LayoutTests/animations/width-using-ems-expected.txt
Sending        LayoutTests/animations/width-using-ems.html
Sending        LayoutTests/platform/win/Skipped
Transmitting file data .......................................
Committed revision 39187.