Rewrite animations layout tests to take advantage of the new DRT API: pauseAnimationAtTimeOnElementWithId() Currently, many the animation tests measure CSS property values after a given elapsed time and they use setTimeout() a delay of about one second or more. This slows down the tests quite a bit, has imprecision problems (since you can't guarantee you're measuring at a precise time), and is not scalable overall.
Created attachment 25927 [details] Patch v1 Pre-reviewed by Chris Marrin Running animations tests now takes around 5sec instead of +15secs
Comment on attachment 25927 [details] Patch v1 > Index: LayoutTests/platform/win/Skipped > =================================================================== > --- LayoutTests/platform/win/Skipped (revision 39183) > +++ LayoutTests/platform/win/Skipped (working copy) > @@ -445,6 +445,8 @@ http/tests/xmlhttprequest/upload-onprogr > # No transition / animation pause LayoutController API on Windows DRT (https://bugs.webkit.org/show_bug.cgi?id=22239) > animations/animation-drt-api.html > animations/animation-drt-api-multiple-keyframes.html > +animations/keyframes-from-missing.html > +animations/keyframes-to-missing.html > transitions/transition-drt-api.html > transitions/transition-drt-api-delay.html > transitions/transition-shorthand-delay.html It's always sad to lose test coverage on Windows. r=me
Fixed a couple issues noticed by bdash and simon Sending LayoutTests/ChangeLog Sending LayoutTests/animations/animation-test-helpers.js Sending LayoutTests/animations/big-rotation-expected.txt Sending LayoutTests/animations/big-rotation.html Sending LayoutTests/animations/change-keyframes-expected.txt Sending LayoutTests/animations/change-keyframes-name-expected.txt Sending LayoutTests/animations/change-keyframes-name.html Sending LayoutTests/animations/change-keyframes.html Sending LayoutTests/animations/change-one-anim-expected.txt Sending LayoutTests/animations/change-one-anim.html Sending LayoutTests/animations/generic-from-to-expected.txt Sending LayoutTests/animations/generic-from-to.html Sending LayoutTests/animations/import-expected.txt Sending LayoutTests/animations/import.html Sending LayoutTests/animations/keyframe-timing-functions-expected.txt Sending LayoutTests/animations/keyframe-timing-functions.html Sending LayoutTests/animations/keyframes-comma-separated-expected.txt Sending LayoutTests/animations/keyframes-comma-separated.html Sending LayoutTests/animations/keyframes-expected.txt Sending LayoutTests/animations/keyframes-from-missing.html Sending LayoutTests/animations/keyframes-out-of-order-expected.txt Sending LayoutTests/animations/keyframes-out-of-order.html Sending LayoutTests/animations/keyframes-to-missing.html Sending LayoutTests/animations/keyframes.html Sending LayoutTests/animations/lineheight-animation-expected.txt Sending LayoutTests/animations/lineheight-animation.html Sending LayoutTests/animations/matrix-anim-expected.txt Sending LayoutTests/animations/matrix-anim.html Sending LayoutTests/animations/multiple-animations-expected.txt Sending LayoutTests/animations/multiple-animations.html Sending LayoutTests/animations/multiple-keyframes-expected.txt Sending LayoutTests/animations/multiple-keyframes.html Sending LayoutTests/animations/transition-and-animation-1-expected.txt Sending LayoutTests/animations/transition-and-animation-1.html Sending LayoutTests/animations/transition-and-animation-2-expected.txt Sending LayoutTests/animations/transition-and-animation-2.html Sending LayoutTests/animations/width-using-ems-expected.txt Sending LayoutTests/animations/width-using-ems.html Sending LayoutTests/platform/win/Skipped Transmitting file data ....................................... Committed revision 39187.