[build.webkit.org] lldb-webkit-test is failing on Catalina queues

[Aakash Jain]

lldb-webkit-test is failing on various queues. e.g.: https://build.webkit.org/#/builders/33/builds/2099/steps/12/logs/stdio

Checking imports ...
Failed to import dump_class_layout_unittest:
  Traceback (most recent call last):
    File "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python/lldb/__init__.py", line 35, in <module>
      import _lldb
  ModuleNotFoundError: No module named '_lldb'
  
  During handling of the above exception, another exception occurred:
  
  Traceback (most recent call last):
    File "/Volumes/Data/worker/catalina-debug-tests-wk1/build/Tools/Scripts/webkitpy/test/main.py", line 290, in _check_imports
      __import__(name)
    File "/Volumes/Data/worker/catalina-debug-tests-wk1/build/Tools/lldb/dump_class_layout_unittest.py", line 28, in <module>
      import lldb
    File "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python/lldb/__init__.py", line 38, in <module>
      from . import _lldb
  ImportError: dynamic module does not define module export function (PyInit__lldb)


On Apple-Catalina-Debug-WK1-Tests queue this issue started happening about two months back (https://build.webkit.org/#/builders/33/builds/2098 passed and https://build.webkit.org/#/builders/33/builds/2099 failed).

Other examples: https://build.webkit.org/#/builders/33/builds/3104, https://build.webkit.org/#/builders/34/builds/1708, https://build.webkit.org/#/builders/25/builds/4158, https://build.webkit.org/#/builders/13/builds/3957

[Jonathan Bedard]

There isn't a great solution to this, we should probably just stop trying to run this test suite on Catalina.

The problem is that in Big Sur mid-year release, Xcode changed lldb from Python 2 to Python 3. In an effort to support the newer way (because that's what Monterey and presumably future OSes will be using). In order to fix this, we basically have to have two lldb-webkit-test scripts, which doesn't seem worth the trouble. Most development is done on Big Sur and Monterey at this point, I think the engineer effort to "fix" this problem on Catalina is not worth it. Especially since I'm pretty sure lldb debugging still works on Catalina, we would just no longer be defending that fact in automation.

[Alexey Proskuryakov]

> There isn't a great solution to this, we should probably just stop trying to run this test suite on Catalina.

Let's do that then.

[Ryan Haddad]

Created attachment 433798 [details]
Patch

[Aakash Jain]

Comment on attachment 433798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433798&action=review

> Tools/CISupport/build-webkit-org/factories.py:111
> +        if platform.startswith('mac') and not (platform == 'mac-catalina'):

This might be slightly easier to read:
and (platform != 'mac-catalina')

[Ryan Haddad]

(In reply to Aakash Jain from comment #4)
> Comment on attachment 433798 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=433798&action=review
> 
> > Tools/CISupport/build-webkit-org/factories.py:111
> > +        if platform.startswith('mac') and not (platform == 'mac-catalina'):
> 
> This might be slightly easier to read:
> and (platform != 'mac-catalina')
Fair enough, will address before landing. Thanks!

[Ryan Haddad]

Created attachment 433802 [details]
Patch for landing

[EWS]

Committed r280040 (239775@main): <https://commits.webkit.org/239775@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433802 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80795641>

[Ryan Haddad]

*** Bug 226603 has been marked as a duplicate of this bug. ***