Bug 227923 - REGRESSION(r279069): http/tests/websocket/tests/hybi/too-long-payload.html is a constant timeout when using NSURLSESSION_WEBSOCKET
Summary: REGRESSION(r279069): http/tests/websocket/tests/hybi/too-long-payload.html is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-13 14:58 PDT by Alex Christensen
Modified: 2021-07-13 15:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2021-07-13 15:00 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2021-07-13 15:30 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-07-13 14:58:59 PDT 
REGRESSION(r279069): http/tests/websocket/tests/hybi/too-long-payload.html is a constant timeout when using NSURLSESSION_WEBSOCKET
Comment 1 Alex Christensen 2021-07-13 15:00:55 PDT 
Created attachment 433449 [details]
Patch
Comment 2 Alex Christensen 2021-07-13 15:00:58 PDT 
<rdar://problem/80343436>
Comment 3 Chris Dumez 2021-07-13 15:08:06 PDT 
Comment on attachment 433449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433449&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1697
> +    task.get().maximumMessageSize = 0x7FFFFFFFFFFFFFFFull;

Maybe worth a comment to indicate why you chose this value.
Comment 4 Alex Christensen 2021-07-13 15:30:40 PDT 
Created attachment 433451 [details]
Patch
Comment 5 Alex Christensen 2021-07-13 15:56:08 PDT 
r279896