Bug 227916 - [WK2] Push OS state dumping logic down from WebProcess to AuxiliaryProcess
Summary: [WK2] Push OS state dumping logic down from WebProcess to AuxiliaryProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 227917
  Show dependency treegraph
 
Reported: 2021-07-13 12:59 PDT by Wenson Hsieh
Modified: 2021-07-13 21:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (12.40 KB, patch)
2021-07-13 13:16 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Rename method (12.45 KB, patch)
2021-07-13 18:41 PDT, Wenson Hsieh
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-07-13 12:59:39 PDT
...with the intention of using it for `GPUProcess` as well, in a future patch.
Comment 1 Wenson Hsieh 2021-07-13 13:16:46 PDT
Created attachment 433445 [details]
Patch
Comment 2 Tim Horton 2021-07-13 18:24:51 PDT
Comment on attachment 433445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433445&action=review

> Source/WebKit/WebProcess/WebProcess.h:413
> +    RetainPtr<NSDictionary> dictionaryForStateDumper() const final;

Can we make it more clear in the name what this is about? Every time I have encountered this function before it was wildly unclear what state was being dumped and why.
Comment 3 Wenson Hsieh 2021-07-13 18:37:35 PDT
Comment on attachment 433445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433445&action=review

>> Source/WebKit/WebProcess/WebProcess.h:413
>> +    RetainPtr<NSDictionary> dictionaryForStateDumper() const final;
> 
> Can we make it more clear in the name what this is about? Every time I have encountered this function before it was wildly unclear what state was being dumped and why.

Sounds good! I'll rename this to `additionalStateForDiagnosticReport` as we discussed on Slack.
Comment 4 Wenson Hsieh 2021-07-13 18:41:48 PDT
Created attachment 433470 [details]
Rename method
Comment 5 EWS 2021-07-13 19:42:19 PDT
Committed r279902 (239651@main): <https://commits.webkit.org/239651@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433470 [details].
Comment 6 Radar WebKit Bug Importer 2021-07-13 19:43:17 PDT
<rdar://problem/80552993>