Bug 227905 - Remove USE_64KB_PAGE_BLOCK
Summary: Remove USE_64KB_PAGE_BLOCK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-13 08:38 PDT by Michael Catanzaro
Modified: 2021-07-13 14:53 PDT (History)
11 users (show)

See Also:


Attachments
Patch (5.54 KB, patch)
2021-07-13 08:42 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2021-07-13 08:38:18 PDT
I added the USE_64KB_PAGE_BLOCK build option in bug #217989 for use by RHEL. But going forward, I don't need it anymore, and can maintain it downstream where it is needed. (This option might also be useful to SUSE, but they already don't use it, so won't miss it.)

I've seen users who don't understand the consequences of this option enabling it on x86_64, even though there are serious negative consequences and zero benefits to using it. So let's get rid of it.
Comment 1 Michael Catanzaro 2021-07-13 08:42:42 PDT
Created attachment 433407 [details]
Patch
Comment 2 Yusuke Suzuki 2021-07-13 11:35:13 PDT
Comment on attachment 433407 [details]
Patch

r=me
Comment 3 EWS 2021-07-13 14:53:28 PDT
Committed r279892 (239643@main): <https://commits.webkit.org/239643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433407 [details].