There are four properties that were removed from the SVG 2 spec, and which are not supported in other browsers: * color-profile -- we recognize the property but don't do anything with it * color-rendering -- we parse and expose this but don't do anything else with it * glyph-orientation-horizontal -- we do use this in our SVG text layout * kerning -- we do use this too in our SVG text layout Don't see why we shouldn't remove the first two, and we should probably try to remove the second two as well. (The text-orientation and letter-spacing properties are the official replacements for glyph-orientation-horizontal and kerning.)
Also, glyph-orientation-vertical is deprecated, but still is in the spec. But WebKit is the only engine to implement it too.
Relatedly, enable-background is another one that was removed (though from the Filters spec), and which we recognize but don't do anything with.
<rdar://problem/80821560>
Created attachment 435149 [details] Patch
Created attachment 435152 [details] Patch
Created attachment 435157 [details] Patch
Created attachment 435166 [details] Patch
Created attachment 435173 [details] Patch
Created attachment 435183 [details] Patch
This seems reasonable to me for color-profile, color-rendering and enable-background.
@heycam WDYT, looks reasonable?
Comment on attachment 435183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435183&action=review Non-reviewer r=me. > Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:183 > // the above properties are not yet implemented in the engine "this property is not yet implemented in the engine"
Once this patch lands, please file a separate bug for the other properties I mentioned that we should try to remove.
Created attachment 441692 [details] Patch
(In reply to Cameron McCormack (:heycam) from comment #13) > Once this patch lands, please file a separate bug for the other properties I > mentioned that we should try to remove. Sure, I filed https://bugs.webkit.org/show_bug.cgi?id=231948 for this.
Committed r284447 (243207@main): <https://commits.webkit.org/243207@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441692 [details].