Bug 227892 - Web Inspector: REGRESSION(r279510): Elements: Computed: an (i) button is shown for computed property traces
Summary: Web Inspector: REGRESSION(r279510): Elements: Computed: an (i) button is show...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on: 226883
Blocks:
  Show dependency tree / graph
 
Reported: 2021-07-12 17:13 PDT by Devin Rousso
Modified: 2021-07-12 18:57 PDT (History)
6 users (show)

See Also:

Attachments
[Image] screen shot of issue (74.38 KB, image/png)
2021-07-12 17:13 PDT, Devin Rousso 		no flags Details
Patch v1.0 (1.72 KB, patch)
2021-07-12 17:26 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Patch v1.1 (1.72 KB, patch)
2021-07-12 17:50 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-07-12 17:13:37 PDT 
Created attachment 433376 [details]
[Image] screen shot of issue

see attached screen shot

reproduces on any page with any computed property trace
Comment 1 Radar WebKit Bug Importer 2021-07-12 17:15:03 PDT 
<rdar://problem/80490487>
Comment 2 Patrick Angle 2021-07-12 17:26:52 PDT 
Created attachment 433379 [details]
Patch v1.0
Comment 3 Devin Rousso 2021-07-12 17:42:10 PDT 
Comment on attachment 433379 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=433379&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css:154
> +.computed-style-section .property-trace-item .property .contextual-documentation-button {

Can we do an `:is(.name, .colon, .semicolon, .contextual-documentation-button)` instead?
Comment 4 Patrick Angle 2021-07-12 17:50:24 PDT 
Created attachment 433382 [details]
Patch v1.1
Comment 5 EWS 2021-07-12 18:57:31 PDT 
Committed r279862 (239615@main): <https://commits.webkit.org/239615@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433382 [details].