Bug 227868 – [GTK][WPE] Support drawing scrollbar corner

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alice Mikhaylenko]

See the patch.

[Alice Mikhaylenko]

Created attachment 433308 [details]
Patch

[Alice Mikhaylenko]

Created attachment 433309 [details]
Patch

Missed a use outside WebCore.

[Adrian Perez]

Comment on attachment 433309 [details]
Patch

Patch LGTM, we may want to have someone from Apple confirm that the
additional parameter passed around is okay for them :)

[Adrian Perez]

Ah, and please add the [WPE] in the ChangeLog summary line; the port
uses the same code to paint scrollbars nowadays.

[Alice Mikhaylenko]

Yeah, I noticed the macOS scroll corners were slightly broken with scrollbars on the left since there's no way to check that without the new parameter. :) I have no idea how to request RTL flip there though (it uses native scrollbars) so didn't update it.

[Alice Mikhaylenko]

Created attachment 433310 [details]
Patch

Added [WPE].

[Alice Mikhaylenko]

Created attachment 433311 [details]
Patch

And of course I forgot the second changelog in WebKit/. Updated too.

[Michael Catanzaro]

Comment on attachment 433311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433311&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1956
> -        ScrollbarTheme::theme().paintScrollCorner(graphicsContext, scrollCornerRect);
> +        ScrollbarTheme::theme().paintScrollCorner(*this, graphicsContext, scrollCornerRect);

*Technically* this line of the changeset requires owner approval, but it's such a small unproblematic change, only intended to keep this code building, that I think we can skip the formality in this case.

[Alice Mikhaylenko]

Ah yeah, flaky tests again.

[EWS]

Committed r279826 (239587@main): <https://commits.webkit.org/239587@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433311 [details].