Bug 227862 - [GTK] Force dark appearance button in inspector doesn't work
Summary: [GTK] Force dark appearance button in inspector doesn't work
Status: RESOLVED DUPLICATE of bug 208204
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 208204
Blocks:
  Show dependency treegraph
 
Reported: 2021-07-11 16:13 PDT by Alice Mikhaylenko
Modified: 2021-07-13 07:29 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Mikhaylenko 2021-07-11 16:13:32 PDT
Looks like we've never flipped OS_DARK_MODE_SUPPORT for GTK.
Comment 1 Michael Catanzaro 2021-07-11 16:51:47 PDT
Sort of the same as bug #208204. I agree that we need OS_DARK_MODE_SUPPORT.
Comment 2 Alice Mikhaylenko 2021-07-11 16:54:46 PDT
I don't think it depends on that. `color-scheme` is about the native form elements; taking dark mode into account there is separate from having OS_DARK_MODE_SUPPORT.
Comment 3 Alice Mikhaylenko 2021-07-11 16:57:04 PDT
Oh ok. The important context here is https://bugs.webkit.org/show_bug.cgi?id=197947

So with that in mind, yes - it does depend on that indeed.
Comment 4 Alice Mikhaylenko 2021-07-13 07:29:40 PDT
Ok, it doesn't just depend on #208204, they are tied together and can't be fixed separately. Let's mark this one as a dup then.

*** This bug has been marked as a duplicate of bug 208204 ***