Bug 227860 - [Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresentations:]
Summary: [Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-11 10:47 PDT by Jer Noble
Modified: 2021-07-12 10:10 PDT (History)
10 users (show)

See Also:


Attachments
Patch (5.27 KB, patch)
2021-07-11 10:53 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-07-11 10:47:34 PDT
[Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresentations:]
Comment 1 Jer Noble 2021-07-11 10:48:02 PDT
<rdar://80376777>
Comment 2 Jer Noble 2021-07-11 10:53:26 PDT
Created attachment 433290 [details]
Patch
Comment 3 Brady Eidson 2021-07-11 14:53:22 PDT
Comment on attachment 433290 [details]
Patch

What does this due to the swift case in betas that have shipped?
Comment 4 Jer Noble 2021-07-11 15:03:45 PDT
(In reply to Brady Eidson from comment #3)
> Comment on attachment 433290 [details]
> Patch
> 
> What does this due to the swift case in betas that have shipped?

It should restore the .closeAllMediaPresentations() method to the swift mapping header. The deprecated API declaration was never exposed to swift, so to swift code, it appeared as if we just removed the API entirely. See: http://codeworkshop.net/objc-diff/sdkdiffs/ios/15.0/WebKit.html
Comment 5 Brady Eidson 2021-07-11 17:29:35 PDT
Great, then the r+ comes with my r+ too :P
Comment 6 EWS 2021-07-12 10:10:32 PDT
Committed r279833 (239594@main): <https://commits.webkit.org/239594@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433290 [details].