Bug 227858 - [Line layout] "zero width space" (U+200B) is a breaking space
Summary: [Line layout] "zero width space" (U+200B) is a breaking space
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-10 21:13 PDT by zalan
Modified: 2021-08-19 15:23 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2021-07-10 21:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.11 KB, patch)
2021-07-11 20:42 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Patch (2.11 KB, patch)
2021-07-12 08:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.30 KB, patch)
2021-08-19 14:10 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2021-08-19 14:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-07-10 21:13:05 PDT 
soft wrap opportunity
Comment 1 zalan 2021-07-10 21:15:12 PDT 
Created attachment 433284 [details]
Patch
Comment 2 zalan 2021-07-11 20:42:06 PDT 
Created attachment 433297 [details]
Patch
Comment 3 Antti Koivisto 2021-07-12 08:30:02 PDT 
Comment on attachment 433297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433297&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:57
> +    auto curentContent = nextInlineTextItem.inlineTextBox().content();

spelling 'current'
Comment 4 zalan 2021-07-12 08:34:34 PDT 
Created attachment 433320 [details]
Patch
Comment 5 Antti Koivisto 2021-07-12 08:35:13 PDT 
Comment on attachment 433297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433297&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:59
> +    if (curentContent.is8Bit() && !previousContent.is8Bit())
> +        curentContent = String::make16BitFrom8BitSource(curentContent.characters8(), curentContent.length());

Could use a comment.
Comment 6 Radar WebKit Bug Importer 2021-07-17 21:14:18 PDT 
<rdar://problem/80738042>
Comment 7 zalan 2021-08-19 14:10:38 PDT 
Created attachment 435902 [details]
Patch
Comment 8 zalan 2021-08-19 14:31:16 PDT 
Created attachment 435905 [details]
Patch
Comment 9 EWS 2021-08-19 15:23:38 PDT 
Committed r281272 (240697@main): <https://commits.webkit.org/240697@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435905 [details].